Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split parameter_values into fixed & variable parameters in batchrunner #393

Merged
merged 8 commits into from Jul 9, 2017
Merged

Split parameter_values into fixed & variable parameters in batchrunner #393

merged 8 commits into from Jul 9, 2017

Conversation

rht
Copy link
Contributor

@rht rht commented Jul 7, 2017

Fix #307. Based on #374.

devforfu and others added 8 commits July 7, 2017 13:28
@devforfu @rht
Fix dictionary parameters issue for batch runner
228e743
@devforfu @rht
Test adjustment
ad6be4d
@devforfu @rht
Fix params and kwargs support
2d21ace
@devforfu @rht
Add small refactors, fixes for batch runner, and test suite
b7d279d 
- Some common functionality factored out into separate method
- New mock model for test suit
- A default list argument in StagedActivation init replaced with None

Fix PEP8 syntax
@devforfu @rht
Fix coverage fall
378fecb
@njvrzm @rht
Clean up variables; fix parameters handling
7473050
@dmasad @rht
Clean up examples and documentations to reflect explicit params
92bfcf3 
Updating the examples and documentation, and fixing the bug that
disregarded numpy sequences.
@rht
Fix test_visualization param bug
364ad70
@rht rht mentioned this pull request Jul 7, 2017
Closed
@coveralls
Copy link

coveralls commented Jul 7, 2017 •
edited

Coverage Status

Coverage increased (+0.4%) to 82.808% when pulling 364ad70 on rht:dict_params_fix into 5a3a62c on projectmesa:master.

@coveralls
Copy link

coveralls commented Jul 7, 2017 •
edited

Coverage Status

Coverage increased (+0.4%) to 82.808% when pulling 364ad70 on rht:dict_params_fix into 5a3a62c on projectmesa:master.

@rht
Copy link
Contributor Author

rht commented Jul 7, 2017

cc: @devforfu @njvrzm @dmasad ?

@dmasad
Copy link
Member

dmasad commented Jul 9, 2017

Looks good!

@dmasad dmasad merged commit fa50736 into projectmesa:master Jul 9, 2017
@rht rht deleted the dict_params_fix branch July 10, 2017 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gila Bend (Post PyCon Sprints)
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rht @coveralls @dmasad @jackiekazil @devforfu @njvrzm