Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for https://github.com/projectmesa/mesa/issues/2117 #2118

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix for https://github.com/projectmesa/mesa/issues/2117 #2118

wants to merge 3 commits into from

Conversation

OrenBochman
Copy link

this is a test and bug fix for the issue in :

#2117

EwoutH
EwoutH reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for catching this! You are indeed right, the closest choice is deterministic while it shouldn't be.

I have one suggestion to implement it a bit cleaner.

mesa/space.py Show resolved Hide resolved
@EwoutH EwoutH added the bug Release notes label label Apr 23, 2024
EwoutH
EwoutH reviewed Apr 23, 2024
View reviewed changes
mesa/space.py Show resolved Hide resolved
@EwoutH EwoutH mentioned this pull request Apr 23, 2024
Merged
OrenBochman
OrenBochman commented Apr 23, 2024
View reviewed changes
Copy link
Author

@OrenBochman OrenBochman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I see that the test passes and my example that uses this code is not showing the issue anymore. SO +1

@EwoutH
Copy link
Contributor

EwoutH commented Apr 23, 2024

Awesome! Let’s now try to make it faster :)

@tpike3
Copy link
Contributor

tpike3 commented May 5, 2024

@EwoutH Do we want to wait for speed on this one or merge it and do a 2.3.1 to fix the bug?

@EwoutH EwoutH added trigger-benchmarks Special label that triggers the benchmarking CI and removed trigger-benchmarks Special label that triggers the benchmarking CI labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwoutH EwoutH EwoutH left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Release notes label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OrenBochman @EwoutH @tpike3