Integrate Jupyterviz #199
Integrate Jupyterviz #199
Conversation
- build leaflet_viz for map portrayal - build mesa-geo for jupyter
* fix init import
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
===========================================
- Coverage 78.21% 64.34% -13.87%
===========================================
Files 10 13 +3
Lines 693 833 +140
Branches 151 186 +35
===========================================
- Hits 542 536 -6
- Misses 127 268 +141
- Partials 24 29 +5 ☔ View full report in Codecov by Sentry. |
|
The code shouldn't be duplicated as much as possible, otherwise it is much more difficult to maintain. |
Removed the Are you also saying it should import more from Mesa (e.g. the matplotlib)? |
| @@ -0,0 +1,56 @@ | |||
| class UserParam: | |||
There was a problem hiding this comment.
This entire file can be removed and to use the Slider, you can import from mesa.experimental.
There was a problem hiding this comment.
Yep got it.. in retrospect it seem obvious, ahh well such is life
| @@ -0,0 +1,410 @@ | |||
| import sys | |||
There was a problem hiding this comment.
Forking the entire file here is not sustainable. Needs to do it the way it is done here https://github.com/projectmesa/mesa-examples/blob/1933cbc8251ca047273e0f88193f692ccbb86de6/examples/sugarscape_g1mt/app.py#L9.
|
Still rushing through this but let me know what else I need to do so we can get this release before AAG. Sorry for the hassle |
* replace tutorial with geo-schelling * incorporate jupyter bridge * add data necessary for geo-schelling
Unfortunately with my current job, I am always behind so this is not very clean or optimized however this integrates jupyter_viz into mesa_geo
Please also see mesa-examples pull request for browser and jupyter examples
TODO: fix the jupyter version when you try and expand from the cell output to full screen