Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep Locale class up to standard #601

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Keep Locale class up to standard #601

wants to merge 4 commits into from

Conversation

ImUrX
Copy link

@ImUrX ImUrX commented Dec 30, 2022 •
edited

@ImUrX ImUrX marked this pull request as ready for review December 30, 2022 06:39
@zbraniecki
Copy link
Collaborator

Hi @ImUrX - before you commit more time. Could you consider switching this code to Intl.Locale?

@ImUrX
Copy link
Author

ImUrX commented Dec 30, 2022

Damn, imagine reading this comment after I implemented everything...

@ImUrX
Copy link
Author

ImUrX commented Dec 30, 2022

@zbraniecki I will keep this up and just make a new PR

@zbraniecki zbraniecki mentioned this pull request Feb 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Locale regex doesnt take into account UN.M49
2 participants
@ImUrX @zbraniecki