Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include freestanding binaries in workspace #3520

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tiziano88
Copy link
Collaborator

No description provided.

@tiziano88
Copy link
Collaborator Author

@conradgrobler @andrisaar before I spend too much time into this, is there any obvious reason why it should not work?

@andrisaar
Copy link
Collaborator

@conradgrobler @andrisaar before I spend too much time into this, is there any obvious reason why it should not work?

Yes, it won't pick up .cargo/config.toml filed.

@tiziano88
Copy link
Collaborator Author

But I moved things so it's not necessary any more. The target is specified per-crate, and the extra flags are in the top level cargo config. Building the stdlib is not actually necessary as long as we install the target in the dockerfile (which we should do anyways).

@andrisaar
Copy link
Collaborator

Ah. I haven't had a closer look, but I documented some issues in #2654 back in the day.

@tiziano88 tiziano88 force-pushed the tzn_single_workspace branch 2 times, most recently from 8b691a3 to acf032d Compare November 28, 2022 16:00
@tiziano88
Copy link
Collaborator Author

It turns out this works for the most part, except cargo docs and cargo udeps, which for some reason get confused by the lack of stdlib for some of the targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants