Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation with FPC on Windows and Linux #41

Open
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

Makhaon
Copy link

@Makhaon Makhaon commented Sep 13, 2018

Please add fixes for make posssibility to compile JCL with FPC. It could be compiled with stable and trunk versions. It merged with the last source of your repository. Partially supports Linux. On the Delphi could be compiled as before.

@fllsilva
Copy link

fllsilva commented Jul 8, 2019

Does it compile or not in FPC? Almost 1 year since this release and continues to compile in FPC.

Conflicting files
jcl/source/common/JclSysInfo.pas
jcl/source/windows/JclRegistry.pas

@Makhaon
Copy link
Author

Makhaon commented Jul 11, 2019

Which version of the FPC are you using? I will do check.

@Makhaon
Copy link
Author

Makhaon commented Jul 11, 2019

I have included last fixes, you can download version here:
https://github.com/Makhaon/jcl
I just have check compilation in the trunk version on the Windows and Linux.

@fllsilva
Copy link

Which version of the FPC are you using? I will do check.

FPC 3.0.4 / Lazarus 2.0.2

@Makhaon
Copy link
Author

Makhaon commented Jul 15, 2019

I'll do some fixes and update my rep soon

@Makhaon
Copy link
Author

Makhaon commented Jul 18, 2019

I have made some changes, added new separate packeges for Linux. I have checked compilation of all existing FPC packeges under windows and linux, FPC 3.0.4 / Lazarus 2.0.2 and FPC 3.3.1 / Lazarus 2.1.0, all compiled successfully

@fllsilva
Copy link

fllsilva commented Jul 18, 2019

I have made some changes, added new separate packeges for Linux. I have checked compilation of all existing FPC packeges under windows and linux, FPC 3.0.4 / Lazarus 2.0.2 and FPC 3.3.1 / Lazarus 2.1.0, all compiled successfully

First of all, thank you for the help.

I tried to use your private repository but unfortunately the JCL installer does not compile, initially it gives an outdated version error in "jedi.inc", I downloaded the latest version and it gives error in several parts of the installer code.

So I used the official repository and I was replacing only the units that had a compilation error in Lazarus by their units. But it came at a certain point that it did not compile anymore either, I believe it is because you used the feature of a newer version (FPC 3.3.1 / Laz. 2.1.0) but that has not yet been officially released.

JclSimpleXml.pas(71,3) Fatal: Impossível localizar FpStringHash usado por JclSimpleXml do pacote Jcl. [RESOLVEDE] JclFileUtils.pas(1104,3) Fatal: Impossível localizar JclShell usado por JclFileUtils, ppu incompatível=C:\Fontes\Delphi\COMPONENTES\JEDI Jvcl with Jcl\jcl\lib\fpc\x86_64-win64\JclShell.ppu, pacote Jcl

But the big question here is: Does the JEDI project have official support for Lazarus / FPC or not? Because I keep imagining having to make all the corrections every time they launch an update, I'd rather forget JEDI with Lazarus.

From what I noticed you had all the work to integrate the FPC almost one year ago, but no one cared to incorporate the official repository. I did the same thing with a component I adapted from the old RXLib suite, called TJvLookupEdit, I asked more than 5 years ago to incorporate it into the repository and to this day nothing, every release I need to change the official repository to include that component.

@fllsilva
Copy link

Thank you very much for your efforts to help, but I will not try to use the JEDI in Lazarus, the only component that use the package are the "storage" to save infomações forms and manipulate ini files / xml and clear my TJvLookupEdit but I can fix it and do it manually on Lazarus without any problems.

@obones
Copy link
Member

obones commented Jul 18, 2019

Thanks as well for the efforts, here are quick notes:

  1. The JCL is supposed to support FPC
  2. The JVCL will not support Lazarus, because Lazarus does not support the VCL.
  3. This pull request is almost impossible to use because it was created on a very outdated commit and has seen lots of conflicting changes added to its branch

So right now, the required changes cannot be identified and distinguished from all the other non related "noise".
Could anyone please create a branch from the current master, apply the required changes and submit a pull request?

@Makhaon
Copy link
Author

Makhaon commented Jul 19, 2019

I could re-pull my repository (if it'll help), it already merged with current version of the main repo:
https://github.com/Makhaon/jcl
also, if you have fixes, you can send it for me.
And I'll update the jedi.inc file.

@Makhaon
Copy link
Author

Makhaon commented Sep 6, 2019

I made some fixes for Delphi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants