Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stirng smartcase lower #4

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

the-Arioch
Copy link
Contributor

attempt after wiki and tracker were closed

the-Arioch added 12 commits February 12, 2013 10:05
…ting dangling references for upper part of hash list
* CharIsNumberChar should account for ThousandSeparators too, if accounts for DecimalSeparator
Work on #5898 #5893
* StrIsDigit is awful Engrish
* StrIsSubset is nothing but another name for StrConsistsOfChars
* StrIsDigit is nothing but another name for StrConsistsOfChars with proper filters
* StrConsistsOfNumberChars is nothing but another name for StrConsistsOfChars with proper filters
* there are three kinds of checks:
**  target only contains given chars
**  target contains some of given chars
**  target contains (among other) all the given chars
One boolean value was ambiguous to separate those tasks. Now there are three distinct name schemes.
* ToDO : make StrIsDigit and StrConsistsOfNumberChars permit empty strings ???
2) tests for JclStringLists, including Join via StringBuilder
@the-Arioch
Copy link
Contributor Author

funny thing, initial attempt gave me 404 - probably because i did not filled int "description" field

And again, i actually only meant the last commit to be pulled.
Again Github Push is inferior to old plain patchset

@the-Arioch
Copy link
Contributor Author

git.exe pull -v --progress "upstream" master

From https://github.com/project-jedi/jcl

  • branch master -> FETCH_HEAD
    Already up-to-date.

Thus separating the single commit into a pull request cannot be intuitively done even by branching

@obones
Copy link
Member

obones commented Feb 18, 2013

the-Arioch wrote:

funny thing, initial attempt gave me 404 - probably because i did not
filled int "description" field

And again, i actually only meant the last commit to be pulled.
Again Github Push is inferior to old plain patchset

Once again, you are not using the way it should be used. Create a branch
for every pull request you intend to make.
Once the pull has been merged, github gives you a "delete this branch"
option should you feel the urge to delete your branch.

@obones
Copy link
Member

obones commented Feb 18, 2013

the-Arioch wrote:

git.exe pull -v --progress "upstream" master

From https://github.com/project-jedi/jcl

  • branch master -> FETCH_HEAD Already up-to-date. -------------

Thus separating the single commit into a pull request cannot be
intuitively done even by branching


Reply to this email directly or view it on GitHub
#4 (comment).

The procedure is as follows :

  1. Create branch from master
  2. Switch to branch
  3. Commit
  4. Request pull
  5. Delete branch once pull request closed

Sure, it's a change of habit from SVN, but once you're used to it, it's
much simpler for everyone because you were able to do lots of commits in
your branch and they are merged at once in the reference repository. Not
all changes are oneliners...

@the-Arioch
Copy link
Contributor Author

  1. Create branch from master - done
  2. Switch to branch - done
  3. Commit - done
  4. Request pull - done

and the result is up there before you eyes.

@obones
Copy link
Member

obones commented Feb 18, 2013

If you had wanted only one commit to be pulled, then create a branch for that commit alone. Any commit done before or later on the same branch are included in the pull request, that's the way it works.

@the-Arioch
Copy link
Contributor Author

exactly what have been done.

and the result is up there before your eyes.

the-Arioch added 2 commits February 18, 2013 17:25
1) shrinking copy-paste
2) adding delimiters as string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants