Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose structured configuration #630

Merged
merged 1 commit into from Sep 13, 2023
Merged

Expose structured configuration #630

merged 1 commit into from Sep 13, 2023

Conversation

astefanutti
Copy link
Contributor

Issue link

Closes #622

What changes have been made

  • Expose a structured configuration API
  • Adapt server.go to convert CLI options to structured configuration

@astefanutti
Copy link
Contributor Author

/assign @anishasthana @asm582

@asm582
Copy link
Member

asm582 commented Sep 12, 2023

@astefanutti CLI options are used in helm deployment, After this PR can you please tell us what would change wrt helm deployment mode?

@astefanutti
Copy link
Contributor Author

@astefanutti CLI options are used in helm deployment, After this PR can you please tell us what would change wrt helm deployment mode?

@asm582 This PR maintains backward compatibility w.r.t. local development, so the Helm deployment is expected to continue working as before.

@asm582
Copy link
Member

asm582 commented Sep 13, 2023

/LGTM

@openshift-ci openshift-ci bot added the lgtm label Sep 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6e7bbdc into project-codeflare:main Sep 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anishasthana anishasthana anishasthana approved these changes

@metalcycling metalcycling Awaiting requested review from metalcycling

@tardieu tardieu Awaiting requested review from tardieu

Assignees

@asm582 asm582

@anishasthana anishasthana

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose structured configuration for MCAD controllers
4 participants
@astefanutti @asm582 @anishasthana @openshift-merge-robot