Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure deployment of configmap, and ocm-secret permissions. #139

Merged

Conversation

VanillaSpoon
Copy link
Member

@VanillaSpoon VanillaSpoon commented Sep 12, 2023

Issue link

#138

What changes have been made

This pr contains adjustments which deploy necessary configurations for the operation of instascale, including the configmap and instascale-ocm-secret resource permissions.

Verification steps

From an old branch:

  1. Run make deploy to deploy Instascale.
  2. Add your instascale-ocm-secret
  3. Check the pod logs, and there will be a message stating the configmap has not been deployed.
  4. Deploy the Instascale configmap independently.
  5. Instascale will be unable to find the OCM secret and will automatically switch to machinesets. Even if an ocm secret is added.
  6. Run make undeploy

From this branch:

  1. Run make deploy to deploy Instascale.
  2. Add your instascale-ocm-secret.
  3. Check the pod logs, and the configmap and OCM secret should be found correcly.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

config/configmap/instascale_configmap.yaml Outdated Show resolved Hide resolved
config/rbac/instascale_configmap.yaml Show resolved Hide resolved
config/rbac/role.yaml Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
config/configmap/instascale_configmap.yaml Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cc2a63c into project-codeflare:main Sep 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants