New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose structured configuration #136
Expose structured configuration #136
Conversation
/assign @anishasthana @asm582 |
/hold (I want to make sure we get the codeflare-sdk hotfix release out before this is merged in) |
/unhold |
Hey, the Just a quick change to the Dockerfile: # Copy the go source
COPY main.go main.go
COPY controllers/ controllers/
+ COPY pkg/ pkg/ |
@VanillaSpoon great catch, thanks! Fixed in 0c0fa54. |
/LGTM |
/lgtm also :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anishasthana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3db3f4b
into
project-codeflare:main
Issue link
Closes #132
What changes have been made
main.go
to use the structured configurationVerification steps
Start InstaScale, make sure it works as expected.