Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gitlink support #144

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add Gitlink support #144

wants to merge 5 commits into from

Conversation

roman-kozachenko
Copy link
Contributor

#85

aensidhe
aensidhe requested changes Feb 20, 2019
View reviewed changes
Copy link
Member

@aensidhe aensidhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other projects on how to do that

@roman-kozachenko
Copy link
Contributor Author

roman-kozachenko commented Feb 20, 2019 •
edited

@aensidhe I took a look at projects supporting gitlink, and as I see just Install-Package GitLink is not enough for enabling it.
Further investigation is needed.
That is quite strange, but project successfully builds with -c Debug.
Will close pull request for now.

@aensidhe
Copy link
Member

https://github.com/progaudi/msgpack.spec/blob/a219eb0b7b9e3048c314059c0c0342a0a776e041/src/msgpack.spec/msgpack.spec.csproj#L48

@aensidhe aensidhe reopened this Feb 21, 2019
@aensidhe aensidhe added this to To do in Plan for future Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aensidhe aensidhe aensidhe requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Plan for future
  
To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roman-kozachenko @aensidhe