We need a way to test for space existance without exception #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aensidhe
commented
Feb 11, 2018
| { | ||
| using (var tarantoolClient = await Client.Box.Connect(ConnectionStringFactory.GetReplicationSource_1_7())) | ||
| { | ||
| foreach (var pair in (IReadOnlyDictionary<string, ISpace>)tarantoolClient.Schema) |
There was a problem hiding this comment.
This will be pain in the ass, because you always forced to cast schema to exact interface.
roman-kozachenko
approved these changes
Feb 12, 2018
| { | ||
| using (var tarantoolClient = await Client.Box.Connect(ConnectionStringFactory.GetReplicationSource_1_7())) | ||
| { | ||
| foreach (var pair in (IReadOnlyDictionary<string, ISpace>)tarantoolClient.Schema) |
There was a problem hiding this comment.
How about exposing IndexByName and IndexById as IReadonlyDictionaries instead of decoration?
There was a problem hiding this comment.
box.Schema.IndexByName ?
There was a problem hiding this comment.
Sorry, typo, should be:
- Properties IndexByName and IndexById in Space
- Properties SpaceByName and SpaceById in Schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing
IReadOnlyDictionaryseems to be reasonable choice, but question arises: what should we return in untyped Enumerator?