Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformatted timestamps on log entries and force focus on log text window. #112

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Jeff-Moorhead
Copy link

@Jeff-Moorhead Jeff-Moorhead commented Jul 6, 2018

I have implemented two improvements in this pull request. First, I added cleaner formatting for the timestamps in the user log. Dates now appear like "July 6, 2018 at 8:29AM" instead of the hard to read raw datetime object. This will allow users to more easily navigate their log. Secondly, I added one line of code that forces the cursor to move to the log window when the user wants to create an entry, so that the user doesn't have to click into the window. This improvement will allow for a more seamless user experience.

I moved a lot of stuff around and refactored a lot of the classes and functions in the project. I restructured the project into a more pythonic package structure, with a main.py file so the project can be run using "python -m prog-o-meter". Lastly, I implemented a means of user data storage that is much cleaner by using json in one single users.json file, rather than creating individual text files for each user. This way, the program will store users.json in the project directory, rather than the current directory.

Please let me know if there is anything in my code that does not comply with the project contribution guidelines!

If this is your first pull request to the prog-o-meter project, we would really appreciate it if you would fill out this Google form.
This lets us know more about our contributors, and what we can do to make it easier and nicer to contribute to the prog-o-meter project.
Please submit your answer here and put an 'x' in the box below.

  • [x ] It is my first pull request to prog-o-meter, and I have answered the survey
  • This is not my first contribution to the prog-o-meter

…instead of displaying a raw datetime object. Timestamps are now displayed like 'July 5, 2018 at 8:47PM', which is more user-friendly than the unformatted datetime.
…project into a package structure with __init__.py and run UI from __main__.py
…aged project with __init__.py. UI now runs from __main__.py
…than .txt. Dictionary-like structure is more efficient and cleaner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant