Issue #1288: In this next round of SFTP transfer optimizations, we ca… #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…che the initial results of the `dir_check()` function at the start of the transfer. According to flamegraphs, there is a fair amount of CPU time spent in `dir_check()` and related functions, almost all of which is redundant. Those access checks apply to conditions which do not change over the course of the data transfer.
Castaglia
force-pushed
the
sftp-xfer-cache-dir-checks-issue1288
branch
from
7da23e2
to
cc5b564
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…che the initial results of the
dir_check()function at the start of the transfer.According to flamegraphs, there is a fair amount of CPU time spent in
dir_check()and related functions, almost all of which is redundant. Those access checks apply to conditions which do not change over the course of the data transfer.