Elapsed time based scoreboard updates #1485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has two advantages: - Update the scoreboard in a single call making xfer_done and elasped_time come from the same moment and reducing scoreboard update overhead - During FTP uploads the number of received bytes also get updated in XFER_DONE making ftpwho -o json display "transfer_bytes" for uploads as well Signed-off-by: Marton Balint <cus@passwd.hu>
This commit removes the previously used blocksize or filesize percentage based scoreboard updates and starts using elapsed time based scoreboard updates. Percent based scoreboard updates could have been too infrequent for big files and slow link speeds, blocksize based scoreboard updates could have been too frequent for fast links. Also this changes the meaning of PR_TUNABLE_XFER_SCOREBOARD_UPDATES, previously it meant the number of transferred blocks to wait until a scoreboard update happened, now it means the number of deciseconds to wait between subsequent scoreboard updates. Deciseconds as the unit were chosen so the default of PR_TUNABLE_XFER_SCOREBOARD_UPDATES of 10 is unchanged and will mean a scoreboard update every second.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #1484.