Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazily read lines in ts_file_server #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

b20n
Copy link

@b20n b20n commented Aug 6, 2013

This change allows tsung to use a very large file as a variable source; each read will seek to an arbitrary location in the file and perform a read.

It's possible (likely, even) that this change will reduce performance of the variable sourcing feature; I can imagine using a config flag to enable it, perhaps. FWIW I haven't observed a serious degradation of performance in my usage.

Usage remains identical.

@tisba
Copy link
Collaborator

tisba commented Nov 2, 2017

I kind of like the idea.

While working #237 to make file_server scale linearly with the number of nodes, I quickly noticed that larger file are quite a bit of a problem.

While this might have a slight impact on access, I don't think this is a big problem. The current eager loading of largish files poses a bigger problem. A 100MB file currently causes memory spikes up to 900-1000MB.

What do you think about that, @nniclausse?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants