Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link in documentation_style_guide.md #7051

Closed
wants to merge 1 commit into from

Conversation

lottihill
Copy link
Contributor

Resolves #7050

Changes:

Added the missing link in the sentence:
'Use the idioms recommended in this guide.'

Now links to:
https://github.com/processing/p5.js/blob/main/contributor_docs/contributing_to_the_p5.js_reference.md

Screenshots of the change:

Before
Screenshot (43)
After
image

Added the missing link in the sentence:
'Use the idioms recommended in this guide.'

Now links to:
https://github.com/processing/p5.js/blob/main/contributor_docs/contributing_to_the_p5.js_reference.md
Copy link

welcome bot commented May 16, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@limzykenneth
Copy link
Member

@lottihill Sorry I think I misunderstood what you were asking before. The "this guide" mentioned in the changes you made here refers to the current document instead of the document being linked to in this PR. The link that needs to be changed is this one.

For the "this guide" I think it can potentially be linked somewhere in this document, @nickmcintyre can probably provide a bit more context.

@Qianqianye
Copy link
Contributor

Thanks @lottihill. Closing this PR because it's fixed in #7053

@Qianqianye Qianqianye closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing link in documentation_style_guide.md
3 participants