-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
probe-rs info
improvements & corrections
#2461
Conversation
info
& corrections
dc1a334
to
739e63b
Compare
info
& correctionsprobe-rs info
improvements & corrections
This PR went in a big circle. I ended up removing the half-baked part identification parts, I have a better idea how to approach that problem now. |
return Ok(()); | ||
}; | ||
|
||
if part_info.peripheral_type() == PeripheralType::Custom && part_info.name() == "Atmel DSU" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the kind of thing I do not want :/ Special casing per chip in random places. It will deteriorate as quick as OpenOCD :/
Do we have any plans to make this more generic? I am not against special casing (we need it) but we should have a system for it where one can add any number of cases without littering the code. Similar to let's say a service router (not exactly like that ofc :D).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any plans to make this more generic?
This isn't per chip, this is per manufacturer :) I hear your concern and we'll see what I can do here. I have plans for chip identification but that idea isn't very well integrated into the "parse random ROM tables and print their data" idea of info
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok :) I am fine with having this for now, but let's put emphasis on cleaning it up rather soon :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I like this, thanks! I added some comments that are a bit more than nitpicks for me :)
According to the Cortex M23 reference manual, the processor has an FPB, not a BPU. This is sligthly interesting since the FPB's IDs are close enough to the M33's BPU, but I think we should remain consistent with the documentation.
That being said the M23/33 components are slightly off. The reference manual lists the following components for M23:
M33 also lists TPUI instead of MTB but I didn't go further than to note this.
The PR also prints more info about the devices.
ATSAMD51 before:
ATSAMD51 after:
ATSAML10 before:
ATSAML10 after: