Clean variable cache #2441
Clean variable cache #2441
Conversation
| @@ -42,6 +42,7 @@ mod register { | |||
| memory_mapped_bitfield_register! { | |||
| /// B3.2.3 CPUID Base Register | |||
| #[allow(non_camel_case_types)] | |||
| #[allow(clippy::upper_case_acronyms)] | |||
There was a problem hiding this comment.
Maybe we should make these allows part of the macro?
| $(#[$outer])* | ||
| #[doc= concat!("A [`bitfield::bitfield!`] register mapping for the register `", $reg_name, "` located at address `", stringify!($addr), "`.")] | ||
| #[derive(Copy, Clone)] | ||
| ($vis_modifier) struct $struct_name($reg_type); |
| .clipping(threshold, &mut remainder) | ||
| .collect(); | ||
| assert_eq!(result, expected); | ||
| assert_eq!(remainder, input.len() - expected.len()); |
There was a problem hiding this comment.
This makes very little sense to me. If we intend the iterator to be collected, why does it count the remainder? And if it's not intended to be collected, why do we show this as the example?
I guess I'd not actually implement this functionality as an iterator, but instead a function that takes an iterator and returns (Vec<T>, usize).
There was a problem hiding this comment.
This was just a nerdout to try and make it work and I had to stash that work :D
I will go the function route with a Vec :)
There was a problem hiding this comment.
I also understand the allure of going overboard and I think "slapping on each others' hands" might not be a bad idea to avoid overcomplicating what doesn't need to be :)
No description provided.