Rebase of #2119 and some related cleanups #2415

bugadani · 2024-04-29T13:37:30Z

probe-rs/src/probe/arm_debug_interface.rs

probe-rs/src/architecture/arm/sequences.rs

bugadani force-pushed the cleanup-arm branch from 9ebb31c to 2ffa480 Compare April 29, 2024 14:57

bugadani added the skip-changelog This PR does not require a changelog entry on release label Apr 30, 2024

bugadani marked this pull request as draft April 30, 2024 06:20

bugadani changed the title ~~Clean up arm_debug_interface::perform_transfers~~ Clean ups in arm_debug_interface Apr 30, 2024

bugadani force-pushed the cleanup-arm branch from 5c65027 to beec099 Compare April 30, 2024 06:52

bugadani changed the title ~~Clean ups in arm_debug_interface~~ Rebase of #2119 and some related cleanups Apr 30, 2024

bugadani force-pushed the cleanup-arm branch 3 times, most recently from 5ababc6 to 7b471c1 Compare April 30, 2024 18:47

bugadani marked this pull request as ready for review April 30, 2024 20:28

bugadani force-pushed the cleanup-arm branch from 3b492be to 839121d Compare May 2, 2024 14:38

bugadani mentioned this pull request May 4, 2024

Can't Flash STM32F750N8Hx #2311

Open

Yatekii reviewed May 4, 2024

View reviewed changes

probe-rs/src/probe/arm_debug_interface.rs Show resolved Hide resolved

Yatekii reviewed May 4, 2024

View reviewed changes

probe-rs/src/probe/arm_debug_interface.rs Outdated Show resolved Hide resolved

bugadani and others added 16 commits May 4, 2024 20:55

Remove unnecessary condition

0b75187

Reuse is_write

bb2c2e0

Avoid looking up inserted item after push

df09b17

Extract write protocol into variable

e7ccf1f

Untangle transfer processing

a56b374

Remove redundant count tracking

e032ee3

Clean up a bit

ba4823d

Clean up parse_swd_response

208ed74

arm: retry WAIT errors at a lower level. Fixes nrf51 flashing.

cfc5678

Clean up perform_swd_transfers

5bede9d

Only update wait cycles of unsuccessful transfers

5915517

Abort transport on timeout

acb34ed

Make tests pass

e5966e8

Clean up

97a7bb7

Shorten extra read generation

06634dc

Reuse more code

1d47411

bugadani added 5 commits May 4, 2024 20:55

Only retry the WAITed operation

35031e5

Unbreak

fea162f

Remove unused line_reset statistic

b4d029b

Use slice::from_mut instead of 1-el array

4cfbbd5

Clean up misleading digit grouping

104e6cd

bugadani force-pushed the cleanup-arm branch from 839121d to 4638364 Compare May 4, 2024 19:03

bugadani added 2 commits May 4, 2024 21:03

Handle parity errors in parse_swd_response

4638364

Be a bit more strict in what ack patterns to tolerate

35fd953

Tiwalun reviewed May 10, 2024

View reviewed changes

probe-rs/src/architecture/arm/sequences.rs Outdated Show resolved Hide resolved

Clean up unnecessary from_micros

5bfe601

Dirbaio mentioned this pull request May 16, 2024

arm: retry WAIT errors at a lower level. Fixes nrf51 flashing. #2119

Closed

1 task

Yatekii approved these changes May 16, 2024

View reviewed changes

Yatekii added this pull request to the merge queue May 16, 2024

Merged via the queue into probe-rs:master with commit 2a8de0d May 16, 2024
19 checks passed

bugadani deleted the cleanup-arm branch May 16, 2024 19:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebase of #2119 and some related cleanups #2415

Rebase of #2119 and some related cleanups #2415

bugadani commented Apr 29, 2024 •

edited

Rebase of #2119 and some related cleanups #2415

Rebase of #2119 and some related cleanups #2415

Conversation

bugadani commented Apr 29, 2024 • edited

bugadani commented Apr 29, 2024 •

edited