Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the ORBTrace mini probe #2110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Disasm
Copy link
Contributor

@Disasm Disasm commented Jan 28, 2024

This PR adds support for the ORBTrace probe. Currently only SWO-based tracing is supported.

I'm not sure if it's a good way to implement a CMSIS-DAP based device with overrides for SWO handling, but I'm open to better options :)

Tested with the orbmule target board and the following command:
cargo run --bin probe-rs --features=cli -- itm --probe 1209:3443 --chip stm32f730V8Tx swo 10000 16000000 8000000

@adamgreig
Copy link
Member

It feels like there must be a better way to handle this, given it's 95% a normal cmsis-dap device, with just some extra support for parallel trace. Does the normal async SWO tracing work, i.e. using cmsis-dap to set baud and manchester/uart?

@Disasm
Copy link
Contributor Author

Disasm commented Jan 28, 2024

The standard way to handle SWO is a third endpoint within CMSIS-DAP v2 interface. Unfortunately, in ORBTrace this endpoint is part of a different interface, and not supported by CMSIS-DAP. Configuration is also quite different.

@adamgreig
Copy link
Member

Ah, I see it doesn't support SWO over CMSIS-DAP at all, that's a shame! Perhaps this is the best way then, and at least it can re-use essentially all the cmsisdap module.

By the way, the changelog update needs to be a separate file in the changelog/ directory, not a change to the actual CHANGELOG.md file.

@Disasm Disasm changed the title Add support for ORBTrace Add support for the ORBTrace mini probe Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants