Trying to fix the color on location info #2063
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresovela
reviewed
Jan 30, 2024
| (true, false) => "{L} {s}\n└─ {m} @ {F}:{l}", | ||
| (true, true) => { | ||
| fileinfo.push_str("{t} {L} {s}\n"); | ||
| fileinfo.push_str(&"└─ {m} @ {F}:{l}".dimmed()); |
There was a problem hiding this comment.
IIRC this won't work because the color information somehow gets lost when you go from ColoredString to String. I don't remember the details.
What you're trying to do should be supported by the defmt log formatter with this format string:
Suggested change
| fileinfo.push_str(&"└─ {m} @ {F}:{l}".dimmed()); | |
| fileinfo.push_str(&"{└─ {m} @ {F}:{l}%dimmed}"); |
But the current version of defmt does not support this yet, we need a new release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.