Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid "symbolIcon.constantForeground" Color #375

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rroessler
Copy link

Description

The color for "symbolIcon.constantForeground" was not indexed, and as such would be ignored by VS-Code.

Merge checklist

  • Added/updated colors
  • Tested in GitHub Light Default theme

The color for "symbolIcon.constantForeground" was not indexed, and as such would be ignored by VS-Code.
Copy link

changeset-bot bot commented Nov 14, 2023

⚠️ No Changeset found

Latest commit: c029d84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rroessler
Copy link
Author

In looking over the outputs of the "getTheme" function, there are also various "undefined" properties as well. Should I change this pull request to instead add a filter/error handling for bad color values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant