Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xtr #519

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Xtr #519

wants to merge 19 commits into from

Conversation

riyazbhat
Copy link
Collaborator

@riyazbhat riyazbhat commented Apr 19, 2024

Pull Request

What does this PR do?

Integrate XTR Model Support and Modified colbertv2 Indexing

Notes:

  • Replace (issue) above ↑↑↑ with the issue this PR closes to automatically link the two.
    This must be done when the PR is created.
  • Add multiple Closes #(issue) as needed.
  • If this PR is work towards but does not close an issue, simply tag the issue without mentioning Closes.

Description

Describe the changes proposed by this PR below to give the reviewer context below ↓↓↓

This pull request focuses on integrating support for the XTR model, a highly efficient multi-vector model, and modifying the colbertv2 indexing to seamlessly incorporate this new model. Below are the key changes and additions made in this PR:

  1. Implemented XTR, a cutting-edge multi-vector model renowned for its efficiency and effectiveness. This implementation is based on the research paper.
  2. Adapted the colbertv2 indexing functionality to seamlessly integrate with the newly introduced XTR model.
  3. Made the model weights for the implemented XTR model readily accessible on the Hugging Face model repository, checkpoint.
  4. Notebook for indexing and retrieval is available here.
  5. It's worth noting that while this PR implements the XTR model based on the available research paper, the full official implementation from the authors is yet to be released.
  6. As of the latest update, the authors have only provided the inference code for the XTR model on 8th April 2024. Therefore, this implementation serves as an early integration of the XTR model into our system, pending the official release of the complete implementation from the authors.

Request Review

Be sure to request a review from one or more reviewers (unless the PR is to an unprotected branch).

Versioning

When opening a PR to make changes to PrimeQA (i.e. primeqa/) master, be sure to increment the version following
semantic versioning. The VERSION is stored here
and is incremented using bump2version {patch,minor,major} as described in the (development guide documentation)[development.html].

  • Have you updated the VERSION?
  • Or does this PR not change the primeqa package or was not into master?

After pulling in changes from master to an existing PR, ensure the VERSION is updated appropriately.
This may require bumping the version again if it has been previously bumped.

If you're not quite ready yet to post a PR for review, feel free to open a draft PR.

Releases

After Merging

If merging into master and VERSION was updated, after this PR is merged:

Checklist

Review the following and mark as completed:

  • Tag an issue or issues this PR addresses.
  • Added description of changes proposed.
  • Review requested as appropriate.
  • Version bumped as appropriate.
  • New classes, methods, and functions documented.
  • Documentation for modified code is updated.
  • Built documentation to confirm it renders as expected (see here).
  • Code cleaned up and commented out code removed.
  • Tests added to ensure all functionalities tested at >= 60% unit test coverage (see here).
  • Code cleaned up and commented out code removed.
  • Release created as needed after merging.

@riyazbhat riyazbhat marked this pull request as ready for review April 25, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants