Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ijcai tutorial #517

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Ijcai tutorial #517

wants to merge 16 commits into from

Conversation

jdpsen
Copy link
Collaborator

@jdpsen jdpsen commented Sep 2, 2023

Pull Request

What does this PR do?

Links IJCAI tutorial details to PrimeQA page.

Closes #(issue)

Notes:

  • Replace (issue) above ↑↑↑ with the issue this PR closes to automatically link the two.
    This must be done when the PR is created.
  • Add multiple Closes #(issue) as needed.
  • If this PR is work towards but does not close an issue, simply tag the issue without mentioning Closes.

Description

Describe the changes proposed by this PR below to give the reviewer context below ↓↓↓

(description)

Request Review

Be sure to request a review from one or more reviewers (unless the PR is to an unprotected branch).

Versioning

When opening a PR to make changes to PrimeQA (i.e. primeqa/) master, be sure to increment the version following
semantic versioning. The VERSION is stored here
and is incremented using bump2version {patch,minor,major} as described in the (development guide documentation)[development.html].

  • Have you updated the VERSION?
  • Or does this PR not change the primeqa package or was not into master?

After pulling in changes from master to an existing PR, ensure the VERSION is updated appropriately.
This may require bumping the version again if it has been previously bumped.

If you're not quite ready yet to post a PR for review, feel free to open a draft PR.

Releases

After Merging

If merging into master and VERSION was updated, after this PR is merged:

Checklist

Review the following and mark as completed:

  • Tag an issue or issues this PR addresses.
  • Added description of changes proposed.
  • Review requested as appropriate.
  • Version bumped as appropriate.
  • New classes, methods, and functions documented.
  • Documentation for modified code is updated.
  • Built documentation to confirm it renders as expected (see here).
  • Code cleaned up and commented out code removed.
  • Tests added to ensure all functionalities tested at >= 60% unit test coverage (see here).
  • Code cleaned up and commented out code removed.
  • Release created as needed after merging.

jdpsen and others added 14 commits October 24, 2023 15:30
Signed-off-by: Jaydeep Sen <jaydesen@in.ibm.com>
Signed-off-by: Jaydeep Sen <jaydesen@in.ibm.com>
Signed-off-by: Jaydeep Sen <jaydesen@in.ibm.com>
Signed-off-by: Jaydeep Sen <jaydesen@in.ibm.com>
remove uninstall torch-scatter as it is not installed

Signed-off-by: Bhavani Iyer <69366014+bhavani105@users.noreply.github.com>
 pip install torch-scatter -f https://data.pyg.org/whl/torch-2.10.0+cpu.html

Signed-off-by: Bhavani Iyer <69366014+bhavani105@users.noreply.github.com>
Signed-off-by: Bhavani Iyer <69366014+bhavani105@users.noreply.github.com>
Signed-off-by: Bhavani Iyer <69366014+bhavani105@users.noreply.github.com>
Signed-off-by: Bhavani Iyer <69366014+bhavani105@users.noreply.github.com>
Signed-off-by: Bhavani Iyer <69366014+bhavani105@users.noreply.github.com>
"anyio<4.0.0": ["install", "gpu"],

Signed-off-by: Bhavani Iyer <69366014+bhavani105@users.noreply.github.com>
Copy link
Collaborator

@bhavani105 bhavani105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Bhavani Iyer <69366014+bhavani105@users.noreply.github.com>
Signed-off-by: Bhavani Iyer <69366014+bhavani105@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants