Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDAPDR minor fixes #513

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

kakugawa
Copy link

@kakugawa kakugawa commented Aug 3, 2023

Pull Request

What does this PR do?

Closes #512

Description

  • Created a conda environment.yml file.
  • Fixed the devices argument.
  • Made the boolean arguments optional.
  • Fixed experiment in generate_ColBERTv2_zeroshot_results.py.
  • Add another check to found_query in train_reranker.py.
  • Don't recalculate zero_shot_ranking_filename.
  • Get the best_checkpoint_path from the Trainer.
  • Fixed old dataset paths.
  • Auto-create required directories.

Request Review

Be sure to request a review from one or more reviewers (unless the PR is to an unprotected branch).

Versioning

When opening a PR to make changes to PrimeQA (i.e. primeqa/) master, be sure to increment the version following
semantic versioning. The VERSION is stored here
and is incremented using bump2version {patch,minor,major} as described in the (development guide documentation)[development.html].

  • Have you updated the VERSION?
  • Or does this PR not change the primeqa package or was not into master?

After pulling in changes from master to an existing PR, ensure the VERSION is updated appropriately.
This may require bumping the version again if it has been previously bumped.

If you're not quite ready yet to post a PR for review, feel free to open a draft PR.

Releases

After Merging

If merging into master and VERSION was updated, after this PR is merged:

Checklist

Review the following and mark as completed:

  • Tag an issue or issues this PR addresses.
  • Added description of changes proposed.
  • Review requested as appropriate.
  • Version bumped as appropriate.
  • New classes, methods, and functions documented.
  • Documentation for modified code is updated.
  • Built documentation to confirm it renders as expected (see here).
  • Code cleaned up and commented out code removed.
  • Tests added to ensure all functionalities tested at >= 60% unit test coverage (see here).
  • Code cleaned up and commented out code removed.
  • Release created as needed after merging.

@kakugawa kakugawa mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant