Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toast): message VNode support #5707

Open
wants to merge 2 commits into
base: v4
Choose a base branch
from

Conversation

antlionguard
Copy link
Contributor

@antlionguard antlionguard commented May 8, 2024

I just added VNode support to Toast message for making Toast more flexible usage.

For example
Screenshot 2024-05-08 at 21 50 58

resolves #5708

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 7:12pm
primevue-v4 ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 7:12pm

@antlionguard antlionguard changed the title Toast message vnode support Toast message VNode support May 8, 2024
@antlionguard antlionguard changed the title Toast message VNode support feat(toast): message VNode support May 8, 2024
@tugcekucukoglu tugcekucukoglu added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label May 16, 2024
@antlionguard
Copy link
Contributor Author

maybe this feature can be added to all components. table, listbox etc. but this seems to be a bit of a hard work. but if you need help if you are going to do something like this, I will be happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants