Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autocomplete): hideOnOptionSelect #5665

Conversation

bogdan0083
Copy link

@bogdan0083 bogdan0083 commented Apr 30, 2024

Right now it's impossible to prevent listbox from hiding when option is selected. I want to be able to leave it open when option is selected and hide it on escape keydown or when clicked outside.

This PR is NOT a breaking change, because hideOnOptionSelect is true by default.

See this and this for a detailed feature request.

Please let me know If I need to update something else in terms of docs.

Thanks!

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 5:41am
primevue-v4 ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 5:41am

@bogdan0083 bogdan0083 changed the title Feat/autocomplete close on select feat(autocomplete): hideOnOptionSelect Apr 30, 2024
@antlionguard
Copy link
Contributor

i think hideOnSelect is more understandable instead of hideOnOptionSelect

@bogdan0083
Copy link
Author

i think hideOnSelect is more understandable instead of hideOnOptionSelect

Yeah, that’s true. I decided to use hideOnOptionSelect because we also have chips and they can be focused. This adds a little bit of ambiguity.

renaming the prop is not a problem. Let’s see what maintainers will say.

@bogdan0083
Copy link
Author

@tugcekucukoglu Hi! Sorry for pinging you directly. Can you please check it out? This feature is covered by tests to make sure it doesn't break anything.

@tugcekucukoglu
Copy link
Member

Thank you for your recent PR. We appreciate your effort and determination to improve our project. However, after careful consideration, we inform you that we cannot accept the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants