Fix#11814: Support DefaultCommand for submit button outside (but linked to) form #11878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o allow using them in JavaScript code
…port submit buttons that are placed outside (but linked to) the form
melloware
approved these changes
May 6, 2024
|
This actually looks really reasonable to me. |
|
what about normal button, linkbutton or commandlink? |
…pport DefaultCommand usage
I updated the implementation to support commandlink. Referencing a form in a normal button and linkbutton doesn't seem to be supported however. |
|
Agreed this would only work from CommandXXX types thanks for adding CommandLink |
tandraschko
reviewed
May 19, 2024
primefaces/src/main/java/org/primefaces/component/commandlink/CommandLinkRenderer.java
Outdated
Show resolved
Hide resolved
|
+1 then |
|
@BjornJaspers unfortunately this fix cannot be merged in the 13.X branch that you have it marked for. Can you resubmit this under branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11814
This is how I thought about fixing this, but of course I'm open for discussion.