[5기 김강훈, 이수진] Spring Boot JPA 게시판 구현 미션 제출합니다. #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kkangh00n <kig2454@gmail.com>
Co-authored-by: kkangh00n <kig2454@gmail.com>
Co-authored-by: kkangh00n <kig2454@gmail.com>
Co-authored-by: kkangh00n <kig2454@gmail.com>
Co-authored-by: kkangh00n <kig2454@gmail.com>
Co-authored-by: kkangh00n <kig2454@gmail.com>
Co-authored-by: kkangh00n <kig2454@gmail.com>
Co-authored-by: kkangh00n <kig2454@gmail.com>
Co-authored-by: kkangh00n <kig2454@gmail.com>
Co-authored-by: kkangh00n <kig2454@gmail.com>
Co-authored-by: kkangh00n <kig2454@gmail.com>
hoon-space
reviewed
Nov 26, 2023
| */ | ||
| @PostMapping("/{postId}") | ||
| @Transactional | ||
| public ResponseEntity<UpdatePostResponse> updatePost(@PathVariable Long postId, @RequestBody UpdatePostRequest updatePostRequest) { |
There was a problem hiding this comment.
@RequestBody 에 postId 를 넣는 건 어떤가요 ?
Comment on lines
+39
to
+42
| Long userId = createPostRequest.getUserId(); | ||
| String title = createPostRequest.getTitle(); | ||
| String content = createPostRequest.getContent(); | ||
| Long postId = postService.create(userId, new PostDto(title, content)); |
There was a problem hiding this comment.
파라미터를 하나하나 뽑아서 넘겨주는 방식이라면, mapper function 을 사용하는게 깔끔할 것 같아요
Comment on lines
+71
to
+73
| List<FindPostResponse> findPostResponseList = postListDto.getPostDtoList().stream() | ||
| .map(it -> new FindPostResponse(it.getId(), it.getTitle(), it.getContent())) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
요런 개체 프로세싱 작업은 서비스 레이어나 별도 메서드로 빼는 건 어떤가요 ??
Comment on lines
+12
to
+16
| public class CreatePostRequest { | ||
|
|
||
| private Long userId; | ||
| private String title; | ||
| private String content; |
|
|
||
| int count; | ||
|
|
||
| List<FindPostResponse> findPostResponseList; |
There was a problem hiding this comment.
보통 변수명에 List 단어를 사용하는 것 보다는 복수형으로 사용해요
|
|
||
| @Getter | ||
| @Entity | ||
| @Table(name = "users") |
Comment on lines
+11
to
+20
| @Component | ||
| @RequiredArgsConstructor | ||
| public class initDB { | ||
|
|
||
| private final UserService userService; | ||
|
|
||
| @PostConstruct | ||
| public void init(){ | ||
| userService.dbinit(); | ||
| } |
There was a problem hiding this comment.
테스트 용도라면 테스트 패키지에 있어도 좋을 것 같아요.
비즈니스 코드에 있는 패키지에는 없어도 될 것 같아요
| public Long update(Long postId, String content) { | ||
| Post post = postRepository.findById(postId).orElseThrow(); | ||
| post.setContent(content); | ||
| return postId; |
There was a problem hiding this comment.
팀미팅때에도 이야기헀지만, 업데이트 ID 만 리턴하는 것은 효율적이지 않은 것 같아요
Comment on lines
+25
to
+30
| @Transactional | ||
| public Long create(Long userId, PostDto postDto) { | ||
| User user = userRepository.findById(userId).orElseThrow(); | ||
| Post post = new Post(postDto.getTitle(), postDto.getContent(), user); | ||
| Post savedPost = postRepository.save(post); | ||
| return savedPost.getId(); |
Comment on lines
+1
to
+11
| spring.datasource.driver-class-name = org.h2.Driver | ||
| spring.datasource.url = jdbc:h2:mem:test;MODE=MySQL | ||
|
|
||
| spring.jpa.hibernate.ddl-auto = create-drop | ||
| spring.jpa.database-platform = org.hibernate.dialect.H2Dialect | ||
|
|
||
| spring.datasource.hikari.maximum-pool-size = 4 | ||
| spring.datasource.hikari.pool-name = H2_TEST_POOL | ||
|
|
||
| ### FOR DEBUGGING ### | ||
| logging.level.org.hibernate.SQL = debug |
hoon-space
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
👩💻 요구 사항과 구현 내용
✅ 피드백 반영사항
✅ PR 포인트 & 궁금한 점