[4기 - 박상민] SpringBoot Weekly Mission 여섯 번째 PR 제출합니다. #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seung-hun-h
reviewed
Aug 9, 2023
| public class Page<T> { | ||
| private final List<T> contents; | ||
| private final int numberOfElements; | ||
| private final Pageable pageable; |
There was a problem hiding this comment.
Pageable을 인스턴스 멤버로 가지고 있을 필요가 있나요?
Page<T>가 가진 정보와 중복된 데이터가 많아서, 필요한 데이터만 들고있으면 될 것 같아서요
|
|
||
| import java.util.UUID; | ||
|
|
||
| public record CustomerUpdateDto( |
| import java.util.UUID; | ||
| import java.util.concurrent.ConcurrentHashMap; | ||
|
|
||
| @Repository |
There was a problem hiding this comment.
MemoryVoucherRepository profile로 분리해줘도 좋을 것 같아요
Comment on lines
+20
to
+23
| spring: | ||
| config: | ||
| activate: | ||
| on-profile: web |
Comment on lines
+36
to
+46
| @GetMapping("/vouchers") | ||
| @ResponseStatus(HttpStatus.OK) | ||
| public Page<VoucherResponse> findVouchers(@ModelAttribute Pageable pageable) { | ||
| return voucherService.findVoucherByPage(pageable); | ||
| } | ||
|
|
||
| @GetMapping("/all") | ||
| @ResponseStatus(HttpStatus.OK) | ||
| public VoucherResponses listVouchers() { | ||
| return voucherService.list(); | ||
| } |
Comment on lines
+36
to
+40
| @GetMapping("/{email}") | ||
| @ResponseStatus(HttpStatus.OK) | ||
| public CustomerResponse findCustomer(@PathVariable @Valid @Email String email) { | ||
| return customerService.findByEmail(email); | ||
| } |
Comment on lines
+17
to
+23
| public UUID save(Voucher voucher) { | ||
| if (storage.containsKey(voucher.getVoucherId())) { | ||
| throw new IllegalStateException(ALREADY_EXISTS); | ||
| } | ||
| storage.put(voucher.getVoucherId(), voucher); | ||
| return voucher.getVoucherId(); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
✅ 피드백 반영사항
#865 (review)
save 랑 update는 에러 발생시키도록 변경하였고 find는 Optional.empty() 반환하도록 변경하였습니다.