Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Open Collective #60

Closed

Conversation

monkeywithacupcake
Copy link

Hi, I'm making updates for Open Collective. Either you or another core contributor signed this repository up for Open Collective. This pull request adds financial contributors from your Open Collective https://opencollective.com/craftjs ❤️

What it does:

  • adds a badge to show the latest number of financial contributors
  • adds a banner displaying contributors to the project on GitHub
  • adds a banner displaying all individuals contributing financially on Open Collective
  • adds a section displaying all organizations contributing financially on Open Collective, with their logo and a link to their website

P.S: As with any pull request, feel free to comment or suggest changes.

Thank you for your great contribution to the Open Source community. You are awesome! 🙌
And welcome to the Open Collective community! 😊

Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other Open Source sustainers!

Comment on lines +234 to +238
### Code Contributors

This project exists thanks to all the people who contribute. [[Contribute](CONTRIBUTING.md)].
<a href="https://github.com/prevwong/craft.js/graphs/contributors"><img src="https://opencollective.com/craftjs/contributors.svg?width=890&button=false" /></a>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this, since we already have the all-contributors section above

@@ -228,12 +229,40 @@ Craft.js is made with :heart: by these wonderful people ([emoji key](https://all

This project follows the [all-contributors](https://github.com/all-contributors/all-contributors) specification. Contributions of any kind are welcome!

## Contributors
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we combine this with the Support section from below?

Suggested change
## Contributors
## Support :heart_decoration:
Craft.js is released under the [MIT license](https://github.com/prevwong/craft.js/blob/master/LICENSE) and is built with 100% love. If you found it useful and would like to ensure its continued development, please consider becoming a backer/sponsor or making a one-time donation via <a href="https://opencollective.com/craftjs/contribute" target="_blank">Open Collective</a> or <a href="https://paypal.me/prevwong" target="_blank">Paypal</a>.


### Financial Contributors

Become a financial contributor and help us sustain our community. [[Contribute](https://opencollective.com/craftjs/contribute)]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the "Contribute" text/link here? It feels a bit redundant. (Same for the Organizations section below)

Comment on lines +9 to 10
<a href="https://opencollective.com/craftjs" alt="Financial Contributors on Open Collective"><img src="https://opencollective.com/craftjs/all/badge.svg?label=financial+contributors&style=for-the-badge" /></a>
</div>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this badge, it makes the heading area a bit crowded 😄

@prevwong
Copy link
Owner

@monkeywithacupcake Thank you for the PR, sorry for getting back on this late! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants