Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the order of appearance:
There are some lerna specific keys, which probably don't work from
package.json
. They should be configured inlerna.json
where they already actually are.The
ignore
pattern should probably contain theexamples
folder instead?Have you changed the folder structure in the past?
Shouldn't the intermediarypackages
object be removed fromworkspaces
?I am not fluent with lerna, but when I searched resources to understand it, it seems that the syntax of
package.json
workspaces
remains managed byyarn
.https://medium.com/@jsilvax/a-workflow-guide-for-lerna-with-yarn-workspaces-60f97481149d
https://legacy.yarnpkg.com/blog/2017/08/02/introducing-workspaces/
I moved several blocks in package.json files so that they all follow same structure. It's then easier to read and maintain them.
Does it make sense to link sibling packages internally to save space and to make them use latest/local version of other packages? This is good for local development to be able to test the examples against a local forked version.