Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Package json #29

Closed
wants to merge 2 commits into from
Closed

[WIP] Package json #29

wants to merge 2 commits into from

Conversation

ackvf
Copy link

@ackvf ackvf commented Jan 27, 2020

In the order of appearance:

There are some lerna specific keys, which probably don't work from package.json. They should be configured in lerna.json where they already actually are.

The ignore pattern should probably contain the examples folder instead?
Have you changed the folder structure in the past?

Shouldn't the intermediary packages object be removed from workspaces?
I am not fluent with lerna, but when I searched resources to understand it, it seems that the syntax of package.json workspaces remains managed by yarn.
https://medium.com/@jsilvax/a-workflow-guide-for-lerna-with-yarn-workspaces-60f97481149d
https://legacy.yarnpkg.com/blog/2017/08/02/introducing-workspaces/

I moved several blocks in package.json files so that they all follow same structure. It's then easier to read and maintain them.

Does it make sense to link sibling packages internally to save space and to make them use latest/local version of other packages? This is good for local development to be able to test the examples against a local forked version.

@ackvf
Copy link
Author

ackvf commented Jan 28, 2020

I have just found about the new workspaces syntax here https://legacy.yarnpkg.com/blog/2018/02/15/nohoist/#how-to-use-it

Can I change the PR to Draft?

@ackvf ackvf changed the title Package json [WIP] Package json Feb 10, 2020
@prevwong
Copy link
Owner

There are some lerna specific keys, which probably don't work from package.json. They should be configured in lerna.json where they already actually are.

I don't see it, could you show me which keys specifically?

The ignore pattern should probably contain the examples folder instead?

The command accepts a glob of package names to ignore. In this case, I specified example-* to ignore example-basic and example-landing.

Does it make sense to link sibling packages internally to save space and to make them use latest/local version of other packages?

Yarn/Lerna already does this automatically for us.

@prevwong prevwong closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants