Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check comment printed before printComment #8743

Closed
wants to merge 1 commit into from

Conversation

fisker
Copy link
Member

@fisker fisker commented Jul 13, 2020

We check not printed comments,

astComments.forEach((comment) => {
if (!comment.printed) {
throw new Error(
'Comment "' +
comment.value.trim() +
'" was not printed. Please report this error!'
);
}
delete comment.printed;
});

I think make sense to prevent comments print multiple times too.

This can prevent #8736 happens.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker marked this pull request as draft July 13, 2020 09:16
@fisker
Copy link
Member Author

fisker commented Jul 14, 2020

Turns out this is not easy as I thought, maybe look into it later, closing now.

@fisker fisker closed this Jul 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant