Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update eslint related dependencies (major) #16208

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore(deps): update eslint related dependencies (major) #16208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
668aea7
chore(deps): update eslint related dependencies
renovate[bot] May 28, 2024
509a06c
Fix build script
fisker Apr 8, 2024
b2628a3
Disable `eslint-plugin-react`
fisker May 28, 2024
a8134cb
Downgrade `eslint-plugin-unicorn`
fisker May 28, 2024
803d826
Dedupe
fisker May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 15 additions & 15 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import eslintConfigPrettier from "eslint-config-prettier";
import eslintPluginImport from "eslint-plugin-import";
import eslintPluginJest from "eslint-plugin-jest";
import eslintPluginN from "eslint-plugin-n";
import eslintPluginReactConfigRecommended from "eslint-plugin-react/configs/recommended.js";
// import eslintPluginReactConfigRecommended from "eslint-plugin-react/configs/recommended.js";
import eslintPluginRegexp from "eslint-plugin-regexp";
import eslintPluginSimpleImportSort from "eslint-plugin-simple-import-sort";
import eslintPluginUnicorn from "eslint-plugin-unicorn";
Expand Down Expand Up @@ -417,23 +417,23 @@ export default [
],
},
},
...compat
.env({ browser: true, worker: true })
.map((config) => ({ ...config, files: ["website/**/*"] })),
Object.assign(eslintPluginReactConfigRecommended, {
files: ["website/**/*"],
settings: {
react: {
version: "18",
},
},
}),
// ...compat
// .env({ browser: true, worker: true })
// .map((config) => ({ ...config, files: ["website/**/*"] })),
// Object.assign(eslintPluginReactConfigRecommended, {
// files: ["website/**/*"],
// settings: {
// react: {
// version: "18",
// },
// },
// }),
{
files: ["website/**/*"],
rules: {
"react/display-name": "off",
"react/no-deprecated": "off",
"react/prop-types": "off",
// "react/display-name": "off",
// "react/no-deprecated": "off",
// "react/prop-types": "off",
"unicorn/filename-case": "off",
},
},
Expand Down
12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,9 @@
"devDependencies": {
"@babel/generator": "7.24.6",
"@eslint/eslintrc": "3.1.0",
"@eslint/js": "8.57.0",
"@eslint/js": "9.3.0",
"@glimmer/reference": "0.92.0",
"@stylistic/eslint-plugin-js": "1.8.1",
"@stylistic/eslint-plugin-js": "2.1.0",
"@types/eslint__js": "8.42.3",
"@types/estree": "1.0.5",
"@types/file-entry-cache": "5.0.4",
Expand All @@ -126,14 +126,14 @@
"esbuild": "0.21.3",
"esbuild-plugins-node-modules-polyfill": "1.6.4",
"esbuild-visualizer": "0.6.0",
"eslint": "8.57.0",
"eslint": "9.3.0",
"eslint-config-prettier": "9.1.0",
"eslint-formatter-friendly": "7.0.0",
"eslint-plugin-compat": "4.2.0",
"eslint-plugin-import": "2.29.1",
"eslint-plugin-jest": "27.9.0",
"eslint-plugin-n": "16.6.2",
"eslint-plugin-react": "7.34.1",
"eslint-plugin-jest": "28.5.0",
"eslint-plugin-n": "17.7.0",
"eslint-plugin-react": "7.34.2",
"eslint-plugin-regexp": "2.6.0",
"eslint-plugin-simple-import-sort": "12.1.0",
"eslint-plugin-unicorn": "52.0.0",
Expand Down
11 changes: 4 additions & 7 deletions scripts/build/build-javascript-module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,10 @@ function getEsbuildOptions({ file, files, shouldCollectLicenses, cliOptions }) {
process: transform,
},
// #12493, not sure what the problem is, but replace the cjs version with esm version seems fix it
...[
require.resolve("tslib"),
createRequire(require.resolve("tsutils")).resolve("tslib"),
].map((file) => ({
module: file,
path: file.replace(/tslib\.js$/, "tslib.es6.js"),
})),
{
module: require.resolve("tslib"),
path: require.resolve("tslib").replace(/tslib\.js$/, "tslib.es6.js"),
},
// https://github.com/evanw/esbuild/issues/2103
{
module: getPackageFile("outdent/lib-module/index.js"),
Expand Down