Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup m2c #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Setup m2c #38

wants to merge 1 commit into from

Conversation

Kelebek1
Copy link

No description provided.

@RevoSucks
Copy link
Collaborator

What's the point of this PR? What is the need to actually submodule this?

@Kelebek1
Copy link
Author

Kelebek1 commented Oct 26, 2022

To make it easier? Don't see why we wouldn't include it given how required it is for decomps. Plus the repo has to change libultra to use m2c anyway.

A bunch more changes are needed to get diff and splat actually working as well...

@RevoSucks
Copy link
Collaborator

What are you talking about? I've already fully integrated libultra.

@Kelebek1
Copy link
Author

Kelebek1 commented Oct 27, 2022

See the ramrom.h change. m2c can't handle sizeof(long) so this needs to change or it'll throw errors.

Also the repo is already using submodules and updates them on setup, so it seemed fine to add another?

@RevoSucks
Copy link
Collaborator

See the ramrom.h change. m2c can't handle sizeof(long) so this needs to change or it'll throw errors.

Please explain your use case and what this error is.

@RevoSucks
Copy link
Collaborator

Is it still erroring on sizeof long?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants