Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook for altering surefire JVM argLine #23

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

dnskr
Copy link

@dnskr dnskr commented Apr 25, 2024

The change is needed to add -Djdk.attach.allowAttachSelf=true argument to maven-surefire-plugin in prestodb/airlift project to be able to build jmx module on Java 11.
See https://github.com/airlift/airlift/pull/840/files for the change needs to be done in prestodb/airlift.

Cherry-pick of airlift@f5f054e
Co-authored-by: Piotr Findeisen piotr.findeisen@gmail.com

Successful build

dnskr@DESKTOP-C71KJJ0 MINGW64 ~/IdeaProjects/airbase (additional-surefire-args)
$ export JAVA_HOME='C:\Users\dnskr\.jdks\temurin-1.8.0_382' && mvn verify -DskipTests
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO] 
[INFO] airbase-root                                                       [pom]
[INFO] airbase-policy                                                     [jar]
[INFO] airbase                                                            [pom]
...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for airbase-root 104-SNAPSHOT:
[INFO]
[INFO] airbase-root ....................................... SUCCESS [  0.004 s]
[INFO] airbase-policy ..................................... SUCCESS [  0.821 s]
[INFO] airbase ............................................ SUCCESS [  3.560 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  4.665 s
[INFO] Finished at: 2024-04-26T00:22:31+02:00
[INFO] ------------------------------------------------------------------------

Cherry-pick of airlift@f5f054e
Co-authored-by: Piotr Findeisen <piotr.findeisen@gmail.com>
@tdcmeehan tdcmeehan self-assigned this Apr 25, 2024
@dnskr dnskr marked this pull request as draft April 30, 2024 19:19
@tdcmeehan
Copy link

Looks reasonable to me

@dnskr dnskr marked this pull request as ready for review May 1, 2024 17:49
@tdcmeehan tdcmeehan merged commit df95350 into prestodb:master Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants