Skip to content

Commit

Permalink
Fixed documentation around generating absolute URLs with Symfony (#336)
Browse files Browse the repository at this point in the history
Co-authored-by: Yann Eugoné <yeugone@prestaconcept.net>
  • Loading branch information
yann-eugone and Yann Eugoné committed Feb 5, 2024
1 parent 99f3c19 commit 96164f5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions doc/2-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,15 @@ you have to set the base URL of where you sitemap files will be accessible. The
of the URL will also be used to make Router generate URLs with hostname.

```yaml
# config/services.yaml
parameters:
router.request_context.host: your-domain.com
router.request_context.scheme: http
# config/packages/routing.yaml
framework:
router:
default_uri: 'https://your-domain.com'
```

> **Note:** You may noticed that there is nothing specific to this bundle.
> **Note:** You may have noticed that there is nothing specific to this bundle.
> In fact, doing this you just allowed your whole application to generate URLs from the command line.
> Please have a look to Symfony's [official documentation](https://symfony.com/doc/current/console/request_context.html)
> Please have a look to Symfony's [official documentation](https://symfony.com/doc/current/routing.html#generating-urls-in-commands)
> for more information.

Expand Down
2 changes: 1 addition & 1 deletion src/Command/DumpSitemapsCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ protected function configure(): void
null,
InputOption::VALUE_REQUIRED,
'Base url to use for absolute urls. Good example - http://acme.com/, bad example - acme.com.' .
' Defaults to router.request_context.host parameter'
' Defaults to Symfony\'s default routing context'
)
->addOption(
'gzip',
Expand Down

0 comments on commit 96164f5

Please sign in to comment.