New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Todo highlighting in html comments #642

Draft

lggruspe wants to merge 4 commits into preservim:master from lggruspe:todo-comment

Contributor

lggruspe commented Sep 20, 2023

Fixes #369

Highlights TODO, FIXME, XXX and TBD inside html comments.


          Todo highlighting in html comments

57b25a5

alerque previously approved these changes

View reviewed changes


          Merge branch 'master' into todo-comment

d2eef03

alerque dismissed their stale review via

d2eef03

September 20, 2023 09:47

alerque requested changes

View reviewed changes

Member

alerque left a comment

Tests not passing, I'm guessing the behavior is correct just the expectations are incorrect.

test/syntax.vader Show resolved Hide resolved

wincent and others added 2 commits

September 22, 2023 10:29


          docs: fix a couple of small typos in code comments

b600814


          Make todo comment tests pass

8434dfe

Contributor Author

lggruspe commented Sep 22, 2023

I made the tests pass, but there are still some issues with this PR. Currently, it can't detect TODO comments without a preceding space. For example,

<!--TODO this doesn't get highlighted -->
<!-- TODO but this one does -->

lggruspe marked this pull request as draft

September 22, 2023 02:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment