Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space in header regex #598

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lggruspe
Copy link
Contributor

@lggruspe lggruspe commented Sep 16, 2022

Fixes #597

Also adds some tests for HeaderDecrease and HeaderIncrease.

ftplugin/markdown.vim Outdated Show resolved Hide resolved
Copy link
Contributor

@tomtomjhj tomtomjhj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of this change, but I'd like to hear from another reviewer, since some markdown implementations don't require spaces. https://babelmark.github.io/?text=%23asdf

ftplugin/markdown.vim Outdated Show resolved Hide resolved
@lggruspe
Copy link
Contributor Author

We could add an option to toggle this behavior. Maybe g:vim_markdown_hashtags or g:vim_markdown_space_in_atx_header will do?

What do you think, @tomtomjhj?

@alerque
Copy link
Member

alerque commented Nov 24, 2022

See comment in #604 (comment) that covers why we don't know whether this should be merged directly or not. The discussion about what Markdown flavor we are even targeting needs to be resolved first.

@alerque
Copy link
Member

alerque commented Nov 24, 2022

Also just for the record these two PRs are not duplicates, one addresses the syntax rules and one addresses the header level handling rules. Both should be merged, modified, or rejected in the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require space between #s and heading text
3 participants