Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed single-click #853

Closed
wants to merge 1 commit into from
Closed

Fixed single-click #853

wants to merge 1 commit into from

Conversation

blockchainian
Copy link

this pr fixes left click so that it opens/closes the folding.

@raven42
Copy link
Collaborator

raven42 commented Apr 10, 2023

I believe the original intent of the feature was only to allow folding when the open/close character is clicked. It looks like with this change, that is being expanded to open/close the fold if the click occurs anywhere on the line. Am I interpreting that correctly? I think I'm ok with that change, but it would need to be updated to account for nested folds.

If we take a python script like this:

def my_func():
    print("first layer")

    def inner_func():
        print("second layer")

        def inner_inner_func():
            print("third layer")
        print("went back to the second layer")
    print("went back to the first layer")

Then the fold open/close doesn't work for the internal definition of inner_func().

If you can make it work to so this type of definition works as well, then I would be ok merging in this change.

Copy link
Collaborator

@raven42 raven42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks nested folded functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants