New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add env to activation table #1156
feat: add env to activation table #1156
Conversation
@wolfv What do you think? Merge this already (after adding docs) or figuring out a better parsing solution for the variables? |
After merging #972 This feature is to simple and will cause confusion |
@baszalmstra Do you have some smart ideas on how to easily and in a cross-platform way, add these env vars? [activation]
env = { PATH = "$PIXI_PROJECT_ROOT/extra/path:$PATH", MODEL_LOCATION = "$PIXI_PROJECT_ROOT/models"} One of my ideas would be parsing the strings ourself and use rusts |
Yeah that could work but its a little bit more tricky because on Windows the separator for the PATH variable is not |
Will have to try it out as they seem to just use the direct naming but they do support taskfiles per OS. |
Sometimes you really want some variables per environment. I currently use the variables per task but when you have several tasks using the same variable(s), it becomes quite verbose. And you might want a variable to be set without defining a specific task. |
He @beenje, Thanks for the input. I completely agree with you. Still need to get back to this PR to test the above discussed change. |
Note
I'm not a 100% happy with the fact that this doesn't work with environment variables that already exist. For example:
I would expect it to expand variables if you would do:
But like the scripts, this also isn't cross platform/shell.
That said we made the decision to clean this up and release it as a first version so users that can use it will benefit from it and it would give us more time to come up with a good solution.