Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax assertions in preconditioner for ummatched weight and target sizes #2020

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Fujikawas
Copy link
Contributor

Main changes of this PR

The assertions in the preconditioner are relaxed to debug information to allow non-equal sizes of the weight and target to be scaled. This is the case for Wtil in #2010.
Tests are added for this change.

Motivation and additional information

Part of #2010.

Author's checklist

  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I added a changelog file with make changelog if there are user-observable changes since the last release.
  • I added a test to cover the proposed changes in our test suite.
  • For breaking changes: I documented the changes in the appropriate porting guide.
  • I sticked to C++17 features.
  • I sticked to CMake version 3.22.1.
  • I squashed / am about to squash all commits that should be seen as one.

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

@Fujikawas Fujikawas requested a review from uekerman May 13, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants