Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sync events to measure time spend synchronizing #2019

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

fsimonis
Copy link
Member

@fsimonis fsimonis commented May 8, 2024

Main changes of this PR

This PR adds profiling events that measure the time waiting when using syncMode

Motivation and additional information

This allows to correct events with synchronizing sub events and make the trace easier to follow.

Example trace

Author's checklist

  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I added a changelog file with make changelog if there are user-observable changes since the last release.
  • I added a test to cover the proposed changes in our test suite.
  • For breaking changes: I documented the changes in the appropriate porting guide.
  • I sticked to C++17 features.
  • I sticked to CMake version 3.22.1.
  • I squashed / am about to squash all commits that should be seen as one.

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

@fsimonis fsimonis added the enhancement A new feature, a new functionality of preCICE (from user perspective) label May 8, 2024
@fsimonis fsimonis added this to the Version 3.x.x milestone May 8, 2024
@fsimonis fsimonis requested a review from davidscn May 8, 2024 11:40
@fsimonis fsimonis self-assigned this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature, a new functionality of preCICE (from user perspective)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant