-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add secondary data to exsting QN tests #2006
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. Thanks for the push 👍
We no longer have any tests that have no secondary data now. But we could add use all data as primary. You could copy from how things are done here: https://github.com/precice/precice/blob/develop/tests/serial/mapping-nearest-projection/MappingNearestProjectionEdges.cpp
The |
True 👍 but we could still easily increase test coverage with the boolean switch explained above. |
Main changes of this PR
One data set is added to the integrated QN tests and it is supposed to be accelerated as secondary data.
Among the Quasi-Newton integration tests, those with
ILS
acceleration could pass and those withIMVJ
acceleration would fail since there is no proper acceleration to the secondary data.Motivation and additional information
To increase test coverage of secondary data in QN methods as mentioned in issue #1996.
Author's checklist
pre-commit
hook to prevent dirty commits and usedpre-commit run --all
to format old commits.Reviewers' checklist