-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend QN acceleration to waveform iterations #2005
base: develop
Are you sure you want to change the base?
Conversation
@NiklasKotarsky currently this PR does not build on my system and also not in our CI pipeline. Does it build on your system? Did you maybe forget to push some file? |
Yes, it compiles on my system and some of the systems in the CI pipline. This is probably due to different versions of Eigen having different feature support. |
If it is an issue with different eigen version: I once had a similar problem with some features not being supported by the Eigen version used by the CI pipeline and added the following code to resolve this: Lines 18 to 22 in 0d43d14
Which Eigen version are you using on your system? |
Couldn't we instead use a fixed time grid with equally spaced time steps? We could hard-code this number of samples to It could also be very helpful to know how many time steps to include in W (cf. #1996) during initialization already. |
Main changes of this PR
Adds support for Quasi Newton acceleration for waveform iterations.
Motivation and additional information
Implements the algorithm described https://onlinelibrary.wiley.com/doi/10.1002/nme.6443 for fixed time grids. For moving time grids everything will be interpolated to the first time grid from the first time window inside the QNWR class instead of using the waveforms inside the QN method as done in #1834.
For IMVJ variant the same fix for all time steps as described in issue #1996 will be used.
Author's checklist
pre-commit
hook to prevent dirty commits and usedpre-commit run --all
to format old commits.make changelog
if there are user-observable changes since the last release.Reviewers' checklist