Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable a geometric filter for non-global kernel methods #1912

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

davidscn
Copy link
Member

@davidscn davidscn commented Dec 1, 2023

Main changes of this PR

Removes the automatic switch-off of geometric filters for all but global RBFs using globally supported kernel functions.

Motivation and additional information

This seems to be an older relic in the configuration of received meshes.

Author's checklist

  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I added a changelog file with make changelog if there are user-observable changes since the last release.
  • I added a test to cover the proposed changes in our test suite.
  • For breaking changes: I documented the changes in the appropriate porting guide.

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

@fsimonis
Copy link
Member

fsimonis commented Dec 4, 2023

Looks like a small, yet impactful change. Are there any tests affected by this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants