-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an experimental profiling API #1657
base: develop
Are you sure you want to change the base?
Conversation
Is it clear for the user that with In general, I am a bit afraid that we are opening another box for v3.0 🙈 |
I don't think that user events should be synchronised and in this PR they aren't. This can always be done in user code. |
Right now, I don't see the real use-case for these API functions. Main reasons:
To me this API sound more like an extension of the framework we want to couple. |
Yes in theory. A valuable use-case in my mind is allowing to profile adapters of commercial and/or closed-source codes such as Fluent @mtree22 or TAU.
True. However, it would remove the need for custom profiling inside ASTE. Other tools could profit from this functionality, prime example being the micro-manager @IshaanDesai. Hopefully I tagged enough people to get some input 😉 |
IMO, this is useful, but I would postpone it to 3.x. |
This API would be quite useful in the Micro Manager. But the names of the functions confused me a bit, wouldn't |
8e6801c
to
03487f0
Compare
This will also work nicely with #1673 |
Main changes of this PR
This PR adds an experimental profiling API to preCICE.
In user/adapter-code, one can call
pushProfilingSection("name")
to add events andpopProfilingSection()
to stop the last event.These events are marked as fundamental and scoped under
solver.initialize/
orsolver.advance/
.Motivation and additional information
This should simplify the integration of profiling for adapter and tools into the precice profiling.
Closes #1647
Author's checklist
pre-commit
hook to prevent dirty commits and usedpre-commit run --all
to format old commits.make changelog
if there are user-observable changes since the last release.Reviewers' checklist