Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI with address and ub sanitizer #1491

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Run CI with address and ub sanitizer #1491

wants to merge 4 commits into from

Conversation

fsimonis
Copy link
Member

@fsimonis fsimonis commented Nov 28, 2022

Main changes of this PR

This PR runs preCICE with address and undefined behaviour sanitizers inside the CI.
The leak sanitizer is disabled, as dependencies trigger it extensively. (investigation required)

Motivation and additional information

This should prevent bugs in the future.

Closes #262

Author's checklist

  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I added a changelog file with make changelog if there are user-observable changes since the last release.
  • I added a test to cover the proposed changes in our test suite.
  • I sticked to C++17 features.
  • I sticked to CMake version 3.16.3.
  • I squashed / am about to squash all commits that should be seen as one.

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

@fsimonis fsimonis added the bug preCICE does not behave the way we want and we should look into it (and fix it if possible) label Nov 28, 2022
@fsimonis fsimonis added this to the Version 3.0.0 milestone Nov 28, 2022
@fsimonis fsimonis modified the milestones: Version 3.0.0, Version 3.x.x Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug preCICE does not behave the way we want and we should look into it (and fix it if possible)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run tests on CI with address sanitizer enabled
1 participant