Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1plusX Rtd Provider : add First Party Cookie ID option #11493

Merged
merged 3 commits into from
May 21, 2024
Merged

1plusX Rtd Provider : add First Party Cookie ID option #11493

merged 3 commits into from
May 21, 2024

Conversation

luca1x
Copy link
Contributor

@luca1x luca1x commented May 15, 2024

Type of change

  • Bugfix

  • [x ] Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

  • This module used to get our first party identifier via local storage. Adding an option so that it can also read it out from the first party cookie, set by us via JavaScript. By default, we still use LocalStorage.
  • Extended unit tests to cover the parsing of the config described above
  • Using the prebid storeManager to obtain access to local storage and cookie storage. This seems to be a best practice and makes sense imo to be a small refactoring as part of this PR. LMK if I'm not making proper use of this abstraction in my code.

Other information

@luca1x luca1x changed the title [WIP] 1plusX Rtd Provider: Add First Party Cookie ID Option 1plusX Rtd Provider: Add First Party Cookie ID Option May 15, 2024
@luca1x
Copy link
Contributor Author

luca1x commented May 15, 2024

@ChrisHuie ready for a first review, thanks! :)

@ChrisHuie ChrisHuie changed the title 1plusX Rtd Provider: Add First Party Cookie ID Option 1plusX Rtd Provider : add First Party Cookie ID option May 20, 2024
@ChrisHuie ChrisHuie requested a review from osazos May 20, 2024 10:19
osazos
osazos approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@osazos osazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osazos osazos merged commit 1848b66 into prebid:master May 21, 2024
4 checks passed
mkomorski pushed a commit that referenced this pull request May 21, 2024
@luca1x
1plusX Rtd Provider : add First Party Cookie ID option (#11493)
8b0f540 
* 1plusX: Add First Party Cookie ID Option

* 1plusX: Remove Empty Test Case

* 1plusX Rtd Provider: Improve Documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osazos osazos osazos approved these changes

Assignees

@osazos osazos

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luca1x @osazos @ChrisHuie